-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix trajectory display. #2828
base: humble
Are you sure you want to change the base?
Fix trajectory display. #2828
Conversation
Handle change from s to ns in clock time. Display the last trajectory position for a fixed time before looping back around.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Can you retarget this change to 'main'? That is what we use as development head. We can backport any bugfixes to humble or other stable branches.
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
Please target the |
Description
The RViz plugin for displaying planned trajectories handles elapsed time incorrectly. Probably sometime in the last few years the dt passed to
Update
was switched from "s" to "ns," and this plugin wasn't updated.Also, the plugin doesn't show the last pose in the trajectory. When we are on the last pose in the trajectory, we call
displaying_trajectory_message_->getWayPointDurationFromPrevious(current_state_ + 1);
to determine how long to display the pose for. This returns 0 and we accordingly display it for 0s.Instead, I chose to put in a constant 1s display time (scaled by the user's trajectory playback rate) at the end of each trajectory so it will pause at the end briefly before looping back to the start, or disappearing.
Checklist